Repository navigation
DEV-1115: build against driver 0.11.11_beta by default - #135
Merged
Merged
Conversation
The default driver was still 0.11.7_beta, so CI, PR dry runs and local builds tested a driver four releases older than the one Release Android API picks (the newest Java API release). 0.11.11_beta brings fixes that reach Android only through the driver, with nothing to port: - DEV-1266: the IO thread and a timer deadlocked on the instruction list and the device, hanging every later call (seen in 5 of 12 Android HIL inStream runs); - DEV-1306: a stop's reply retired the wrong instruction, so a configuration written straight after stopStreaming() lost its sampling-rate chunk; - DEV-1310: deepClone() of a connected device could throw ConcurrentModificationException, or return null while packets waited. AGENTS.md described the pin as two hard-coded versions and an unpublished shimmerbluetoothmanager; it now describes the single default, the release's -PdriverVersion, and that each Java API release publishes both artifacts. Co-Authored-By: Claude Opus 5.5 <[email protected]>
Contributor
Author
Verified on hardware: the DEV-1266 deadlock is in 0.11.7_beta and gone in 0.11.11_betaI reproduced it with #136's new
Each deadlock's thread dump shows the IO thread blocked in Not covered yet: DEV-1306 and DEV-1310, which this bump also brings, haven't been checked on Android hardware. 🤖 Generated with Claude Code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DEV-1115. The default driver (
-PdriverVersionunset) moves from 0.11.7_beta to 0.11.11_beta, the newest Java API release. It's what CI, PR dry runs and local builds use; Release Android API already picks the newest Java API release, so until now CI tested a driver four releases older than the one a release ships.What 0.11.11_beta brings to Android, with nothing to port
These fixes are in driver code
Shimmerinherits rather than overrides:inStreamruns hung this way on 0.11.7_beta.stopStreaming()lost its sampling-rate chunk, and a command queued after the stop could go unsent. The fix is inoperationPrepare()and the IO thread's stop handling, whichShimmerdoesn't override.deepClone()of a connected device could throwConcurrentModificationException, or return null while packets waited for the processing thread.ShimmerandShimmer3BLEAndroidclone by serialisation and get the driver's fix.The driver's DEV-1275 and DEV-1291 fixes don't reach Android this way, because
Shimmeroverrides the code they changed; they're ported in #132 and #133.Docs
AGENTS.md described the pin as two hard-coded versions and an unpublished
shimmerbluetoothmanager0.11.8_beta. It now describes the single default, the release's-PdriverVersion, and that each Java API release publishes both artifacts at the same version.Tested
CI builds the library and the examples against 0.11.11_beta. The Android HIL runs on the bench with this and the port PRs together before the release.
🤖 Generated with Claude Code